[Webkit-unassigned] [Bug 82155] DFG OSR exit value recoveries should be computed lazily

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 28 02:41:22 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82155





--- Comment #11 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-03-28 02:41:21 PST ---
Attachment 134245 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'S..." exit_code: 1
Source/JavaScriptCore/dfg/DFGVariableEvent.h:235:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/JavaScriptCore/dfg/DFGMinifiedNode.h:58:  The parameter name "nodeIndex" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGMinifiedNode.h:58:  The parameter name "node" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGMinifiedNode.h:65:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/JavaScriptCore/dfg/DFGVariableEventStream.h:52:  The parameter name "codeBlock" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGVariableEventStream.h:52:  The parameter name "codeOrigin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGVariableEventStream.h:52:  The parameter name "graph" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGVariableEventStream.h:53:  The parameter name "operands" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGVariableEventStream.h:56:  The parameter name "event" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGVariableEvent.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 10 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list