[Webkit-unassigned] [Bug 82307] [WebSocket]Browser must fail connection if Sec-WebSocket-Protocol mismatched.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82307





--- Comment #10 from joey <li.yin at intel.com>  2012-03-28 01:48:02 PST ---
(In reply to comment #9)
> (From update of attachment 134047 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134047&action=review
> 
> > Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:728
> > +            m_clientProtocol.split(String(", "), result);
> 
> Using a string literal ", " looks dangerous.  If we changed the protocol string generation code so that it used " , ", this check would not work.

It should be matched with joinStrings(protocols, ", "), which can be found in WebSocket::connect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.