[Webkit-unassigned] [Bug 79354] [EFL] Add dummy GeolocationClientEfl.cpp | h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79354


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134188|review?                     |review-
               Flag|                            |




--- Comment #30 from Ryuan Choi <ryuan.choi at samsung.com>  2012-03-28 00:45:24 PST ---
(From update of attachment 134188)
View in context: https://bugs.webkit.org/attachment.cgi?id=134188&action=review

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.h:50
> +private:
> +    RefPtr<Evas_Object> m_view;
> +};

As discussed in private channel, m_view will be deleted when GelocationClientEfl is terminated.

So, I preferred this as raw pointer like other *ClientEfl.
Or, you need to refactor ewk_view to control reference count well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.