[Webkit-unassigned] [Bug 80269] [Microdata] Implement PropertyNodeList interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80269


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133059|review?                     |review-
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2012-03-27 15:27:14 PST ---
(From update of attachment 133059)
View in context: https://bugs.webkit.org/attachment.cgi?id=133059&action=review

> Source/WebCore/bindings/js/JSMicroDataItemValueCustom.cpp:49
> +    return jsString(exec, itemValue->getString());

Why does this return a string?  We have a MicroDataItemValue.idl in this file.  I would have expected it to return a MicroDataItemValue...

> Source/WebCore/bindings/v8/custom/V8MicroDataItemValueCustom.cpp:48
> +    return v8String(itemValue->getString());

Same question here.

> Source/WebCore/dom/PropertyNodeList.cpp:48
> +        m_propertyValue.append(element->itemValue());

Is this going to keep appending to m_propertyValue every time this function is called?  That doesn't seem right.

> Source/WebCore/dom/PropertyNodeList.cpp:66
> +Node* PropertyNodeList::itemWithName(const AtomicString& id) const

itemWithName not itemWithID ?

> Source/WebCore/dom/PropertyNodeList.h:52
> +    PropertyValueArray getValues();

Is this going to thrash the RefCounts of the MicroDataItemValue?

> Source/WebCore/dom/PropertyNodeList.h:61
> +    PropertyNodeList(Vector<RefPtr<Node> >& nodes)

Please add the explicit keyword.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.