[Webkit-unassigned] [Bug 82376] [Coverity] Address uninit constructor issues

Tue Mar 27 14:20:49 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=82376

James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #134130|review?                     |review-
               Flag|                            |

--- Comment #4 from James Robinson <jamesr at chromium.org>  2012-03-27 14:20:49 PST ---
(From update of attachment 134130)
View in context: https://bugs.webkit.org/attachment.cgi?id=134130&action=review

Most of these changes seem fine, but some do not (see inline comments). Also please fix the tab characters.

> Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp:62
>  #endif
> +    , m_textTrackDisplay(0)

this should be inside the #if ENABLE() guard, not outside of it

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:569
> +    , m_enabled(false)

I'm not sure this is correct - this bool doesn't seem to actually be used. maybe it should be deleted instead?

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:130
> +    , m_resolutionScale(0)

i think 1 is a better value to initialize to

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.