[Webkit-unassigned] [Bug 81848] Show image diffs for gpu_tests on flakiness dashboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81848


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133956|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Ojan Vafai <ojan at chromium.org>  2012-03-27 11:11:02 PST ---
(From update of attachment 133956)
View in context: https://bugs.webkit.org/attachment.cgi?id=133956&action=review

Please fix the nits and upload a new patch for the commit queue.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:1846
> +        } else {
> +            html += ' | <b>Only shows actual results/diffs from the most recent *failure* on each bot.</b>';
> +        }

Single-line  else shouldn't have braces.

> Tools/TestResultServer/static-dashboards/flakiness_dashboard.html:2197
> +        } else {
> +            container.replaceChild(item, dummyNode);
> +        }

Single-line  else shouldn't have braces.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.