[Webkit-unassigned] [Bug 82315] [Texmap][EFL] Implementation of AC related functions in ChromeClientEfl and ewkView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82315





--- Comment #4 from Raphael Kubo da Costa <rakuco at FreeBSD.org>  2012-03-27 07:58:14 PST ---
(In reply to comment #3)
> (From update of attachment 134008 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134008&action=review
> 
> Looks fine overall with one minor comment.
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:154
> > +    Evas_Object* compositingObject;
> 
> You could wrap an OwnPtr around this Evas_Object to avoid having to delete it manually below.

(If you don't do this you should probably check if the pointer is valid before calling evas_object_del()).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.