[Webkit-unassigned] [Bug 82042] Unavailable pre-processor macro in non-Qt environments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 06:25:32 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82042





--- Comment #12 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2012-03-27 06:25:32 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #8)
> > > (From update of attachment 133487 [details] [details] [details])
> > > I'd prefer if this was written without QT_VERSION_CHECK instead of introducing _QT5, i.e.:
> > > 
> > > #if PLATFORM(QT) && QT_VERSION >= 0x050000
> > 
> > The version 3 of the patch uses this approach. Thanks!
> 
> I suggest to mark the patch for review (r?) in order for the EWS to start building and us being able to review it :)

Oops! I guess now it's correct. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list