[Webkit-unassigned] [Bug 79354] [EFL] Add dummy GeolocationClientEfl.cpp | h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79354





--- Comment #23 from Benjamin Poulain <benjamin at webkit.org>  2012-03-27 01:59:08 PST ---
(From update of attachment 133993)
View in context: https://bugs.webkit.org/attachment.cgi?id=133993&action=review

> Source/WebKit/PlatformEfl.cmake:138
> +IF (ENABLE_GEOLOCATION)
> +  LIST(APPEND WebKit_INCLUDE_DIRECTORIES
> +    ${WEBCORE_DIR}/Modules/geolocation
> +  )
> +  LIST(APPEND WebKit_SOURCES
> +    efl/WebCoreSupport/GeolocationClientEfl.cpp
> +  )
> +ENDIF ()

I see you did not follow the indentation of this file. Please fix the indentation.

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.h:27
> +#include "GeolocationPosition.h"

You can skip this header and forward declare this class.

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.h:46
> +    virtual void geolocationDestroyed();
> +
> +    virtual void startUpdating();
> +    virtual void stopUpdating();
> +    virtual void setEnableHighAccuracy(bool);
> +    virtual GeolocationPosition* lastPosition();
> +
> +    virtual void requestPermission(Geolocation*);
> +    virtual void cancelPermissionRequest(Geolocation*);

Why not also having OVERRIDE to avoid future mistake?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.