[Webkit-unassigned] [Bug 79354] [EFL] Add dummy GeolocationClientEfl.cpp | h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79354


Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133741|review?                     |review-
               Flag|                            |




--- Comment #19 from Benjamin Poulain <benjamin at webkit.org>  2012-03-26 22:41:23 PST ---
(From update of attachment 133741)
View in context: https://bugs.webkit.org/attachment.cgi?id=133741&action=review

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.cpp:32
> +    ASSERT(m_view.get());

ASSERT(m_view) will do.

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.cpp:74
> +
> +

Extra spaces

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.h:45
> +    void geolocationDestroyed();
> +
> +    void startUpdating();
> +    void stopUpdating();
> +    void setEnableHighAccuracy(bool);
> +    GeolocationPosition* lastPosition();
> +
> +    void requestPermission(Geolocation*);
> +    void cancelPermissionRequest(Geolocation*);

I suggest you to explicitly mark the client methods with virtual, and to use OVERRIDE.

> Source/WebKit/efl/WebCoreSupport/GeolocationClientEfl.h:48
> +    ~GeolocationClientEfl() { };

Why did you set the destructor as protected for a a concrete class?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.