[Webkit-unassigned] [Bug 78559] [DRT] Create CommonTextInputController to replace common TextInputController usages.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78559





--- Comment #10 from Kangil Han <kangil.han at samsung.com>  2012-03-26 21:53:30 PST ---
Your point makes sense.
I will discard this and make a patch for EFL only.

(In reply to comment #9)
> It looks my last explanation was confused. I'm sorry about that.
> 
> Now, I cannot understand the purpose of this change.
> Whole purpose of TextInputController is to 
> 
> - inspect platform's text input API state. For mac, it's NSTextInput, and to
> - emulate user text input against the platform's text input API. It's also NSTextInput on mac.
> 
> Following this pattern, what you need is to invoke EFL's text input interface through TextInputController
> And this is required only if EFL port is going to implement EFL's (or some other underlying platform's)
> text input protocol.
> 
> If EFL isn't going to support any text input protocol, it makes little sense to support TextInputController
> since it is designed to test that feature. You can just skip tests which exercise text input functionality.
> 
> I know both GTK and Qt implement TextInputController in a similar way.
> But in my opinion, it's kinda autotelic. 
> Having yet another fake implementation just for mocking TextInputController
> will be a pure waste.
> 
> I think you can discuss, say, GTK fork and move their TextInputController with this 
> WebCoreTestSupport version. Then you can employ it for EFL.
> By doing it,
> - we can avoid code duplication at least.
> - we can eliminate manual JS binding code.
> This will help both GTK and EFL port.
> 
> Als, the class name would be MockTextInputController or something.
> It cannot be common for the reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.