[Webkit-unassigned] [Bug 82100] [WebSocket]Reserved bits test case should cover both extension and no-extension scenarios

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 26 17:54:51 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82100





--- Comment #10 from Kenichi Ishibashi <bashi at chromium.org>  2012-03-26 17:54:51 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #4)
> > > If another extension is added, I think the mod_pywebsocket will be updated to support it, meanwhile, many related test case will be required to update.
> > > In addition, the test case echo-with-no-extension_wsh.py also used that statement.
> > 
> > It would be true, but it's not a justification for adding such dependency. We should avoid adding unnecessary dependency like this. Maybe calling disable_outgoing_compression() (see deflate-frame_wsh.py) is enough.
> 
> This test case needs two scenarios, extension and no-extension.
> disable_outgoing_compression() function just used uncompressed frame to transfer data, but it still had negotiated extension. This is not expected.
> And request.ws_extension_processors = [] specified no extension, not only compress extension, but also all the extensions, even if another extension will be added in the future.

Ok. Please wait formal review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list