[Webkit-unassigned] [Bug 82245] W3C testharness.js tests should not require an -expected.txt file

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 26 15:34:42 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=82245





--- Comment #4 from Adam Barth <abarth at webkit.org>  2012-03-26 15:34:42 PST ---
> I find it a bit odd that it's useful to track progress towards conformance by having a set of tests "pass" against expected failures. Wouldn't it be better to have the actual expected result with the test skipped until it conforms?

Often a single test file contains multiple sub-tests, some that pass and some that fail.  The -expected.txt mechanism lets us make sure that we continue to pass the subtests we currently pass rather than forcing us to skip entire groups of tests.

Also, when someone makes a change that improves conformance, it's easy to review diffs to the -expected.txt files as part of the patch review process.  If we skip the tests, then we later have to try unskipping the tests to see what all passes.

I would encourage you to try our current -expected.txt workflow for a while to see what you do and don't like about it.  It seems to have been working fairly well for us for a while.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list