[Webkit-unassigned] [Bug 23166] background-clip doesn't work when border-radius is specified

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23166


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133746|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #26 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-03-26 10:48:56 PST ---
(From update of attachment 133746)
View in context: https://bugs.webkit.org/attachment.cgi?id=133746&action=review

> LayoutTests/fast/css/background-clip-radius-values.html:7
> +    border-radius: 10px 30px;

Please make the radii larger to make potential test failures more obvious.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:637
> +void RenderBoxModelObject::clipComplexRoundedRect(GraphicsContext * context, const LayoutRect& rect, const RoundedRect& clipRect)

GraphicsContext* context

It's not really clear what "complex" means in the method name.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:641
> +    // For non-renderable rounded rectangles there are only two opposing non-zero radii
> +    // (if they are computed from renderable outer border rounded rectangles)

I don't really understand this comment. Can you make it clearer?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.