[Webkit-unassigned] [Bug 79477] [GTK] Add resources API to WebKit2 GTK+

Mon Mar 26 09:05:29 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=79477

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132090|review?                     |review+
               Flag|                            |

--- Comment #6 from Gustavo Noronha (kov) <gns at gnome.org>  2012-03-26 09:05:29 PST ---
(From update of attachment 132090)
View in context: https://bugs.webkit.org/attachment.cgi?id=132090&action=review

Looks good to me!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebResource.cpp:263
> + *   is emitted again with a redirected response, the active URI is the
> + *   redirected URI.

"the active URI is the URI the request was redirected to" sounds better I think

> Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp:300
> +    // No cached resurce: First load.

s/resurce/resource/ (and a few more after this)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.