[Webkit-unassigned] [Bug 82081] [SOUP] Implement WebFrameNetworkingContext for soup in WebKit2

Mon Mar 26 08:26:57 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=82081

--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2012-03-26 08:26:57 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > This is not dead code. The frame loader in FrameLoader::init() creates the networking context with 
> > 
> > If the ::soupSession getter is not used in this patch, I think it should be added in the first patch that uses it.
> 
> soupSession is used by the current code, it's protected by checking whether network context is NULL or not, so currently it's not called because the network context is always NULL in wk2. Patch attached to bug #82082 doesn't introduce a new soupSession call and it doesn't work without this one, that's why I made this bug depend on bug #82082. You can add a printf there if you want to check this code is not dead code.

There were a couple pieces of information missing here: 

1. FrameNetworkingContext is an abstract base class with an abstract method ::soupSession. 
2. The old implementation of WebFrameNetworkingContext, Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebFrameNetworkingContext.h, did not implement that method. Normally it's a compilation error immediately after you try to instantiate a non-concrete implementation of an abstract class. As Carlos said in comment #1 though, the factory method was always returning null.

Without knowing those two things outright, this patch looked very mysterious.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.