[Webkit-unassigned] [Bug 81589] [Qt][WK2] Support multi-file upload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81589


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132715|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2012-03-26 07:36:18 PST ---
(From update of attachment 132715)
View in context: https://bugs.webkit.org/attachment.cgi?id=132715&action=review

r=me, but please fix the conversion before landing

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:384
> +    if (!dialogRunner.initForFilePicker(filePicker, q, selectedFileNames, type))

Hmm, initForFilePicker's last argument is a boolean, but type is an enum. It sounds like that conversion should be a bit more explicit, because like this it's not very readable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.