[Webkit-unassigned] [Bug 82194] Web Inspector: Some user objects are missing in dominators view

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82194





--- Comment #4 from Yury Semikhatsky <yurys at chromium.org>  2012-03-26 06:43:55 PST ---
(In reply to comment #3)
> (From update of attachment 133785 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133785&action=review
> 
> >> Source/WebCore/inspector/front-end/HeapSnapshot.js:234
> >> +        return this._snapshot[this._arrayName].subarray(this._start + start, this._start + end);
> > 
> > Why did this change? Is it a bug?
> 
> Yep, it is not related to the main change. I just noticed it and decided to fix.
> end should be relative to this._start when it is passed in,
> and it should be the end of the outer slice (i.e. this._start + this.length) when it is not.

Does it break anything? If so, can we cover it with a test?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.