[Webkit-unassigned] [Bug 82100] [WebSocket]Reserved bits test case should cover both extension and no-extension scenarios
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 26 06:22:59 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=82100
--- Comment #5 from joey <li.yin at intel.com> 2012-03-26 06:22:59 PST ---
(In reply to comment #3)
> (From update of attachment 133594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133594&action=review
>
> > LayoutTests/ChangeLog:5
> > +
>
> Please add description
>
> > LayoutTests/http/tests/websocket/tests/hybi/reserved-bits.html:17
> > +var bit_extension = ["1_0", "2_0", "3_0", "2_1", "3_1"];
>
> They are not descriptive. Using query string like "compressed=true&bit_number=1" would be better.
Good point, thanks.
>
> > LayoutTests/http/tests/websocket/tests/hybi/reserved-bits_wsh.py:19
> > + request.ws_extension_processors = [] # using no extension response
>
> This will cause unexpected behavior if another extension is added in the future.
>
> > LayoutTests/http/tests/websocket/tests/hybi/reserved-bits_wsh.py:20
> > + else:
>
> You can remove else clause here.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list