[Webkit-unassigned] [Bug 82041] [BlackBerry]Missing cookies from HTTP response header in Network tab of Web Inspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82041





--- Comment #6 from Leo Yang <leo.yang at torchmobile.com.cn>  2012-03-26 02:47:19 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 133455 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=133455&action=review
> > > 
> > > > Source/WebCore/platform/network/blackberry/NetworkJob.cpp:319
> > > > +
> > > > +        if (m_response.httpHeaderFields().contains("Set-Cookie"))
> > > > +            return m_response.setHTTPHeaderField(key, m_response.httpHeaderField(key) + "\r\n" + value);
> > > 
> > > m_response.setHTTPHeaderField(key, value) has been called at the end of this function. Why this is needed here? Are you trying to catenate all 'Set-Cookie' headers to one?
> > 
> > Yes, I catenate them so that overwrite doesn't happen.
> 
> But you are setting "Set-Cookie" header twice for the first "Set-Cookie" header, which is a waste. Why use "\r\n" as delimiter? What do the other ports use?

Never mind, you returned. But is "\r\n" the best delimiter? How other ports deal with this case?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.