[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777





--- Comment #57 from YoungTaeck Song <youngtaeck.song at samsung.com>  2012-03-26 00:25:27 PST ---
Thank you for spending much time about this patch.

(In reply to comment #55)
> (From update of attachment 133727 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133727&action=review
> 
> I haven't read the whole patch yet, but it looks better than the previous versions. I'm a bit unconvinced that using plain select(2) is the best approach here, as it has its fair share of scalability problems. Have you considered using poll() instead, for example?
> 

I don't know about select()'s fair share of scalability problems. Can you explain to me?
In my patch, just two file descriptor is checked, So I think that there is no difference no matter what I use poll, select and epoll.
(I checked this web page. http://daniel.haxx.se/docs/poll-vs-select.html)
When I made this code, I saw Ecore Main Loop source as a reference.
Ecore Main Loop are using select().

> > Source/WebCore/platform/RunLoop.h:171
> > +    static void wakeUpEvent(void*, void*, unsigned int);
> 
> Let me nitpick a bit more :-)
> 
> In general, declarations of methods with basic data types, such as int or void* are expected to contain variable names, as it is not clear at first sight what they are supposed to mean.

I fixed that as follow, "static void wakeUpEvent(void* data, void*, unsigned int);"
because 2,3 arguments are not used.

> 
> > Source/WebCore/platform/efl/RunLoopEfl.cpp:44
> > +    m_initEfl = false;
> 
> Nitpicking a bit more, this kind of variable initialization should be done before the constructor body:
>   RunLoop::RunLoop()
>       : m_initEfl(false)
>   {
>   }

fixed

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.