[Webkit-unassigned] [Bug 82082] [SOUP] Implement missing methods in CookieJarSoup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=82082





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-25 23:27:50 PST ---
(In reply to comment #2)
> (From update of attachment 133546 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133546&action=review
> 
> Nice! Consider reverting the changes to deleteCookiesForHostname and deleteAllCookies. The old style seemed a more explicit about what was happening.

well, not using smart pointers is always more explicit, yes.

> > Source/WebCore/platform/network/soup/CookieJarSoup.cpp:128
> > +        // FIXME we are currently passing false always for seesion because there's no API to know
> 
> Missing a ':' after FIXME.

Ok.

> > Source/WebCore/platform/network/soup/CookieJarSoup.cpp:149
> > +    CString cookieName = name.utf8();
> > +
> 
> Extra newline here.

I'll remove this one.

> > Source/WebCore/platform/network/soup/CookieJarSoup.cpp:165
> > +        GOwnPtr<SoupCookie> cookie(static_cast<SoupCookie*>(item->data));
> 
> It's was actually a bit tricky for me to see how this worked now, with a GOwnPtr assigned the cookie late in its life. I'm not sure if I prefer this approach versus the old one.

what's is tricky exactly? soup_cookie_jar_all_cookies() returns a transfer full GSList, so we need a GOwnPtr for the container and another one for every item.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.