[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777





--- Comment #55 from Raphael Kubo da Costa <rakuco at FreeBSD.org>  2012-03-25 21:51:09 PST ---
(From update of attachment 133727)
View in context: https://bugs.webkit.org/attachment.cgi?id=133727&action=review

I haven't read the whole patch yet, but it looks better than the previous versions. I'm a bit unconvinced that using plain select(2) is the best approach here, as it has its fair share of scalability problems. Have you considered using poll() instead, for example?

> Source/WebCore/platform/RunLoop.h:171
> +    static void wakeUpEvent(void*, void*, unsigned int);

Let me nitpick a bit more :-)

In general, declarations of methods with basic data types, such as int or void* are expected to contain variable names, as it is not clear at first sight what they are supposed to mean.

> Source/WebCore/platform/efl/RunLoopEfl.cpp:44
> +    m_initEfl = false;

Nitpicking a bit more, this kind of variable initialization should be done before the constructor body:
  RunLoop::RunLoop()
      : m_initEfl(false)
  {
  }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.