[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777





--- Comment #51 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-03-25 20:46:00 PST ---
(From update of attachment 133726)
View in context: https://bugs.webkit.org/attachment.cgi?id=133726&action=review

> Source/WebCore/platform/efl/RunLoopEfl.cpp:99
> +void RunLoop::wakeUpEvent(void* data, void* buf, unsigned int size)

Trivial nit : It looks *buffer* is better than *buf*

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:140
> +void WorkQueue::unregisterSocketEventHandler(int fd)

ditto. Abbreviation is not WebKit coding style. It looks we can use fileDescriptor instead of fd.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.