[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777





--- Comment #48 from Ryuan Choi <ryuan.choi at samsung.com>  2012-03-25 19:51:00 PST ---
(From update of attachment 133721)
View in context: https://bugs.webkit.org/attachment.cgi?id=133721&action=review

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:163
> +void WorkQueue::scheduleWorkAndWakeUp(const Function<void()>& function)
> +{
> +    if (function.isNull())
> +        return;
> +
> +    MutexLocker locker(m_workItemQueueLock);
> +    m_workItemQueue.append(function);
> +    sendMessageToThread(wakupThreadMessage);
> +}
> +
> +void WorkQueue::dispatch(const Function<void()>& function)
> +{
> +    scheduleWorkAndWakeUp(function);
> +}
> +

Sorry about incremental review.

But, I think that scheduleWorkAndWakeUp is also unnecessary.

And 
I am not sure but `ASSERT(function.isNull())` is better than `if (function.isNull())`.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.