[Webkit-unassigned] [Bug 62777] [EFL][WK2] Add RunLoopEfl and WorkQueueEfl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62777





--- Comment #43 from Ryuan Choi <ryuan.choi at samsung.com>  2012-03-25 17:52:13 PST ---
(From update of attachment 133448)
View in context: https://bugs.webkit.org/attachment.cgi?id=133448&action=review

> Source/WebCore/platform/efl/RunLoopEfl.cpp:38
> +static const char* const wakupEcorePipeMessage = "W";

Nitpick, static const char wakeupEcorePipeMessage[] = "W";

> Source/WebCore/platform/efl/RunLoopEfl.cpp:48
> +        goto errorEcore;

how about removing errorEcore and returning ?

> Source/WebKit2/Platform/WorkQueue.h:188
> +    class TimerWorkItem;

IMO, this is unnecessary.

> Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:49
> +static const char* const finishThreadMessage = "F";
> +static const char* const wakupThreadMessage = "W";

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.