[Webkit-unassigned] [Bug 80030] [GObject bindings] Supplemental interfaces are not disabled with the "Conditional" attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80030


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133536|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #19 from Martin Robinson <mrobinson at webkit.org>  2012-03-23 14:46:11 PST ---
(From update of attachment 133536)
View in context: https://bugs.webkit.org/attachment.cgi?id=133536&action=review

I'll land this one.

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:117
> +sub HumanReadableConditional {

HumanReadableConditional -> humanReadbleConditional?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:362
> +sub GenerateConditionalWarn

GenerateConditionalWarn -> generateConditionalWarning

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:368
> +    if ($conditional) {

This probably deserves an early return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.