[Webkit-unassigned] [Bug 77835] [GObject bindings] EventListeners as first-class GObjects: WebKitDOMEventListener

Fri Mar 23 13:57:43 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=77835

--- Comment #48 from C Anthony <anthony at xtfx.me>  2012-03-23 13:57:43 PST ---
(In reply to comment #46)
> (From update of attachment 132222 [details])
> I still need to go over this in detail (hopefully next week), but this patch breaks the API, so surely it cannot be right? It's pretty much auto r- because of that, we'll need to figure out something else...

the add/remove_event_listeners currently have a `userData` param in what seems to be an arbitrary location ... i don't know how to remedy that properly?  while i have a few changes to make for other reasons, this patch brings the signatures permanently inline with the DOM spec, and allows for many other uses (eg, DOM spec allows a single EventListener to bind to unlimited EventTargets, current API breaks this, patch fixes by providing a reusable object).

i think the API is already pretty busted, and as-is, simply will never work for anyone but C consumers (ie. introspection-driven bindings like Python will never function, which is my motivation for this to begin with)

the API changes slightly, but there is very little required to update, for the most part its just creating a listener and passing it along instead of passing a raw pointer to a handler.  the signatures are only being corrected.

how does API ever change?  what was needed last year when events moved from signals to functions?  isn't the gobject bindings still green enough to allow for further development?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.