[Webkit-unassigned] [Bug 81451] [Gtk] Webkit fails to build with --disable-geolocation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81451





--- Comment #6 from Zan Dobersek <zandobersek at gmail.com>  2012-03-23 13:52:59 PST ---
(In reply to comment #5)
> (From update of attachment 133541 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133541&action=review
> 
> > Source/WebKit/gtk/webkit/webkitgeolocationpolicydecision.cpp:-26
> > -
> > -using namespace WebCore;
> 
> This is a bit backward? Why removing the namespace use?
> 

Keeping this would require it to be wrapped in an ifdef. Otherwise if geolocation support is disabled, including the Geolocation.h header basically does nothing, meaning the 'using namespace WebCore;' statement causes compilation error.

Because of that I switched to using WebCore::Geolocation rather than polluting the code with another ifdef.

> > Source/WebKit/gtk/webkit/webkitgeolocationpolicydecision.cpp:85
> > +    WEBKIT_WARN_FEATURE_NOT_PRESENT("Geolocation")
> 
> Where does that macro come from?
> A quick grep on the source returns nothing.

This is added in the patch in bug #80030.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.