[Webkit-unassigned] [Bug 81878] [WebSocket]Reserved1 bit should be 0 when no negotiated extension

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81878





--- Comment #13 from Benjamin Poulain <benjamin at webkit.org>  2012-03-23 12:15:34 PST ---
(In reply to comment #12)
> Maybe the test case should be redesigned, it had better cover both no-extension and extension scenarios.
> 
> extension bit1 bit2 bit3
>    yes     0    1    0
>    yes     0    0    1
>    no      1    0    0
>    no      0    1    0
>    no      0    0    1
> 
> The current test case only covered the 1st and 2nd.
> But the 3rd, 4th and 5th were not covered. 
> 
> What's your opinion?

Improving the test coverage sounds good. You should submit the test separately and CC the engineer who made the fix you mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.