[Webkit-unassigned] [Bug 13624] REGRESSION: can select text of an input button

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13624


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133514|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-23 11:42:52 PST ---
(From update of attachment 133514)
View in context: https://bugs.webkit.org/attachment.cgi?id=133514&action=review

> Source/WebCore/rendering/RenderButton.cpp:66
> +    if (node())
> +        return node()->isContentEditable();
> +
> +    return false;

Ugh... this is a render object. You should be calling rendererIsEditable instead. r- because isContentEditable can trigger style recalc.
It's also better to write this as return node() && node()->rendererIsEditable().

> Source/WebCore/rendering/RenderButton.h:43
> +    virtual bool canBeSelectionLeaf() const;

Please use OVERRIDE macro :)

> Source/WebCore/rendering/RenderTextFragment.cpp:68
> +    if (node())
> +        return node()->isContentEditable();
> +        
> +    return false;

Ditto.

> Source/WebCore/rendering/RenderTextFragment.h:42
> +    virtual bool canBeSelectionLeaf() const;

OVERRIDE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.