[Webkit-unassigned] [Bug 59367] [GTK] DRT missing didRunInsecureContent notification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59367





--- Comment #6 from Sergio Villar Senin <svillar at igalia.com>  2012-03-23 09:47:24 PST ---
(From update of attachment 133501)
View in context: https://bugs.webkit.org/attachment.cgi?id=133501&action=review

Great stuff! Hope you keep contributing :)

> Source/WebKit/gtk/ChangeLog:7
> +

You need a brief comment here describing the patch.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:116
> +    // Insecure content

don't think that comment is needed.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:450
> +            0,

IMO it's better just to write this as 0, 0, 0 on the same line

> Tools/ChangeLog:7
> +

Again you need a brief description of the change.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1266
> +static void didRunInsecureContent(WebKitWebFrame* webFrame, WebKitSecurityOrigin* origin, CString url)

I guess you can omit the first two parameter names here.

> LayoutTests/ChangeLog:7
> +

Missing comment here too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.