[Webkit-unassigned] [Bug 75528] Optimize the multiply-add in Biquad.cpp::process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75528





--- Comment #55 from xingnan.wang at intel.com  2012-03-22 19:58:56 PST ---
(In reply to comment #53)
> (In reply to comment #52)
> > (In reply to comment #50)
> > > Does this latest patch pass the layout test (and not crash) on the Debug build?
> > 
> > The layout test passed in both debug and release build from my environment (32-bit).
> > Last crash issue`s root cause is I used 32-bit registers for the address and it will failed in 64-bit system. I use intrinsics this time and suppose it would not meet this issue. Certainly more tests are needed, but I don`t have 64-bit system right now.
> 
> I don't expect any issues with 64-bit builds.  The compiler should use the right sized registers for the intrinsic operations.
> 
> > 
> > Ray, would you mind to help me to check whether the patch is OK in your 64-bit system?
> 
> No problem.  The debug build passes all tests, except for the convolution-mono-mono test, but I think that's a bug in the convolver that needs to be fixed.
> 
> The release build passes all tests too. (convolution-mono-mono passes.)

Ray, thank you for doing the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.