[Webkit-unassigned] [Bug 81887] [BlackBerry] add interface clearCredentials() and clearNeverRememberSites()

Thu Mar 22 19:19:03 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=81887

Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133239|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #4 from Rob Buis <rwlbuis at gmail.com>  2012-03-22 19:19:03 PST ---
(From update of attachment 133239)
View in context: https://bugs.webkit.org/attachment.cgi?id=133239&action=review

Looks good.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:418
> +    HANDLE_SQL_EXEC_FAILURE(!m_database.executeCommand("DELETE FROM never_remember"),

never_remember sounds like it can be improved upon, maybe an english native speaker has a suggestion, will ask in the office.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.