[Webkit-unassigned] [Bug 81748] Add exception for the setter of "fftSize" in RealtimeAnalyserNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81748





--- Comment #10 from xingnan.wang at intel.com  2012-03-22 19:04:48 PST ---
(In reply to comment #9)
> Created an attachment (id=133411)
 --> (https://bugs.webkit.org/attachment.cgi?id=133411&action=review) [details]
> Patch

(In reply to comment #8)
> (From update of attachment 133204 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133204&action=review
> 
> Looking pretty good - just a couple of comments:
> 
> > LayoutTests/webaudio/realtimeanalyser-fft-sizing.html:27
> > +           testFailed("No exception thrown for illegal fftSize" + fftSize + ".");
> 
> You should add an "else" clause here (for illegal==false) with an appropriate testPassed() message.
> 
> > LayoutTests/webaudio/stereo2mono-down-mixing.html:18
> > +var fftSize = 256;
> 
> You can remove changes to this file since https://bugs.webkit.org/show_bug.cgi?id=81881 has been approved and will land first.

Updated the patch as your comments, thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.