[Webkit-unassigned] [Bug 81975] New: DFG NodeFlags has some duplicate code and naming issues

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81975

           Summary: DFG NodeFlags has some duplicate code and naming
                    issues
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fpizlo at apple.com


The notion that some flags are "ArithNodeFlags" is mostly antiquated.

The renaming from NodeUse to Edge messed up some node flags names (NodeUsedAsNum become EdgedAsNum ... ooops).

It appears that we have a method called setArithNodeFlag() which is never called.

It appears that we have both mergeArithNodeFlags and mergeFlags.  The former has some assertions, which may be useful - but it's sad that we have two methods that really do the same thing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.