[Webkit-unassigned] [Bug 71207] An extra line break is inserted when pasting into a font element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71207





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-22 15:05:33 PST ---
(From update of attachment 133329)
View in context: https://bugs.webkit.org/attachment.cgi?id=133329&action=review

>>> Source/WebCore/editing/ReplaceSelectionCommand.cpp:125
>>> +    return createLegacyEditingPosition(parent, n->nodeIndex() + 1);
>> 
>> Why do we always want to move up in the node hierarchy? If we had a bunch of siblings after pos's container node, then we'll still want to skip those. r- because I don't think this is a correct fix.
> 
> The insertion position only move up if the visible positions of the current position and the high level node's position are the same. So, if we had a bunch of siblings after pos's container node, they won't get skipped because of the difference visible positions.

Right, but what if they're empty? If that case, I think we do want to skip those empty elements but moving to the next position in the parent may not be possible due to it being a different visible position.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.