[Webkit-unassigned] [Bug 71207] An extra line break is inserted when pasting into a font element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71207


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133329|review?                     |review-
               Flag|                            |




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-22 13:23:23 PST ---
(From update of attachment 133329)
View in context: https://bugs.webkit.org/attachment.cgi?id=133329&action=review

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:116
> +static Position nextPositionInContainerNode(Position pos)

Please don't use abbreviations like pos.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:120
> +    Node* n = pos.deprecatedNode();    

You should use pos.containerNode(). Also please don't use one-letter variable like n.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:125
> +    return createLegacyEditingPosition(parent, n->nodeIndex() + 1);

Why do we always want to move up in the node hierarchy? If we had a bunch of siblings after pos's container node, then we'll still want to skip those. r- because I don't think this is a correct fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.