[Webkit-unassigned] [Bug 81950] New: Add Android keycodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81950

           Summary: Add Android keycodes
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Android
        OS/Version: Android
            Status: UNCONFIRMED
          Severity: Minor
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bhsu at google.com


WebCore.windowsKeyCodeForKeyEvent() in KeyCodeConversionAndroid.cpp converts Android keycode to WebKit keycode. This file imports the Android keycode definition from <android/keycodes.h>. Some keycodes triggered by normal QWERTY keyboards are not defined in <android/keycodes.h>. A key event is mapped to WebKit keycode zero if its Android keycode is not defined and handled here.

To handle Android keycode not defined in <android/keycodes.h>, KeyCodeConversionAndroid.cpp currently defines and handles two Android keycodes locally, AKEYCODE_MEDIA_PAUSE and AKEYCODE_VOLUME_MORE. The following keycodes could be handled in the same way:

    AKEYCODE_ESCAPE
    AKEYCODE_FORWARD_DEL
    AKEYCODE_CTRL_LEFT
    AKEYCODE_CTRL_RIGHT
    AKEYCODE_CAPS_LOCK
    AKEYCODE_SCROLL_LOCK
    AKEYCODE_META_LEFT
    AKEYCODE_META_RIGHT
    AKEYCODE_BREAK
    AKEYCODE_INSERT
    AKEYCODE_MEDIA_PLAY
    AKEYCODE_F1
    AKEYCODE_F2
    AKEYCODE_F3
    AKEYCODE_F4
    AKEYCODE_F5
    AKEYCODE_F6
    AKEYCODE_F7
    AKEYCODE_F8
    AKEYCODE_F9
    AKEYCODE_F10
    AKEYCODE_F11
    AKEYCODE_F12
    AKEYCODE_NUM_LOCK
    AKEYCODE_NUMPAD_0
    AKEYCODE_NUMPAD_1
    AKEYCODE_NUMPAD_2
    AKEYCODE_NUMPAD_3
    AKEYCODE_NUMPAD_4
    AKEYCODE_NUMPAD_5
    AKEYCODE_NUMPAD_6
    AKEYCODE_NUMPAD_7
    AKEYCODE_NUMPAD_8
    AKEYCODE_NUMPAD_9
    AKEYCODE_NUMPAD_DIVIDE
    AKEYCODE_NUMPAD_MULTIPLY
    AKEYCODE_NUMPAD_SUBTRACT
    AKEYCODE_NUMPAD_ADD
    AKEYCODE_NUMPAD_DOT
    AKEYCODE_CHANNEL_UP
    AKEYCODE_CHANNEL_DOWN

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.