[Webkit-unassigned] [Bug 81748] Add exception for the setter of "fftSize" in RealtimeAnalyserNode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 22 10:43:51 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81748





--- Comment #8 from Chris Rogers <crogers at google.com>  2012-03-22 10:43:51 PST ---
(From update of attachment 133204)
View in context: https://bugs.webkit.org/attachment.cgi?id=133204&action=review

Looking pretty good - just a couple of comments:

> LayoutTests/webaudio/realtimeanalyser-fft-sizing.html:27
> +           testFailed("No exception thrown for illegal fftSize" + fftSize + ".");

You should add an "else" clause here (for illegal==false) with an appropriate testPassed() message.

> LayoutTests/webaudio/stereo2mono-down-mixing.html:18
> +var fftSize = 256;

You can remove changes to this file since https://bugs.webkit.org/show_bug.cgi?id=81881 has been approved and will land first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list