[Webkit-unassigned] [Bug 81884] [GTK] Use the angle-bracket form to include wtf headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81884





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-22 08:04:40 PST ---
(In reply to comment #6)
> (From update of attachment 133210 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133210&action=review
> 
> >>> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp:-34
> >>> -#include <JavaScriptCore/GRefPtr.h>
> >> 
> >> How did these used to work?  Do we need to delete some ForwardingHeaders as well?
> > 
> > good point, I don't know, Martin?
> 
> WebKit2 uses framework style includes (where all the headers are in a single directory), so this should probably become #include <wtf/GRefPtr.h>. The directory of headers is generated by the generate-forwarding-headers script during build. I can fix up all of these includes in a followup commit.

is it worth it? what's the problem of using <wtf/text/CString.h>, it looks more clear to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.