[Webkit-unassigned] [Bug 80005] Implement strict testing criterion for callback function definition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80005





--- Comment #63 from Jeremy Mao <yujie.mao at intel.com>  2012-03-22 01:11:27 PST ---
(In reply to comment #61)
> (From update of attachment 132979 [details])
> I'm afraid I don't think the JSC changes here are correct.  We use a couple of different classes in JSC to represent functions with different characteristics, JSFunction and InternalFunction.  Your isFunction check is only testing for JSFunctions, and not InternalFunctions.  Please see comment #46 for a check that should work.

Hi barraclough, thanks for your feedback, patch is updated. I think a better way to implement the isFunction() is to add a InternalFunctionType(JSFunctionType is already exists) in JSType, and then set each function type inherited from InternalFunction to InternalFunctionType.

BTW, I've tried comments #46, but some wierd errors block me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.