[Webkit-unassigned] [Bug 71788] <area>-tag within <map> can get focus when it is hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71788





--- Comment #17 from Andy Estes <aestes at apple.com>  2012-03-22 00:46:27 PST ---
(In reply to comment #16)
> (From update of attachment 133194 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133194&action=review
> > Source/WebCore/html/HTMLAreaElement.cpp:204
> > +    if (!(image && image->renderer()) || image->renderer()->style()->visibility() != VISIBLE)
> 
> I think this would read better as:
> 
> if (!image || image->renderer() || image->renderer()->style()->visibility() != VISIBLE)

Oops, my suggestion broke your patch! I meant:

if (!image || !image->renderer() || image->renderer()->style()->visibility() != VISIBLE)

I think this is more straight-forward than negating a subexpression.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.