[Webkit-unassigned] [Bug 80255] Optimize for IPP in DirectConvolver::process()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80255





--- Comment #6 from xingnan.wang at intel.com  2012-03-21 20:20:35 PST ---
(In reply to comment #4)
> (From update of attachment 133008 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=133008&action=review
> 
> Xingnan, thanks for the patch.  Have you run the convolution layout tests when WEBAUDIO_IPP is enabled?  Also, please make sure to call m_overlayBuffer.zero() in the reset() method...
> 
All layout tests passed when WEBAUDIO_IPP is enabled, both Debug and Release build.
> > Source/WebCore/platform/audio/DirectConvolver.cpp:74
> > +    float* outputBuffer = m_inputBuffer.data();
> 
> It might make sense to rename this member variable more generally now: m_inputBuffer -> m_buffer
> since it's a bit confusing to see line 74
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.