[Webkit-unassigned] [Bug 81850] MathML internals - improve naming in RenderMathMLSquareRoot.cpp and RenderMathMLRoot.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 17:51:19 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81850


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133155|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2012-03-21 17:51:19 PST ---
(From update of attachment 133155)
View in context: https://bugs.webkit.org/attachment.cgi?id=133155&action=review

LGTM.

> Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp:82
> +        baseWrapper->style()->setPaddingLeft(Length(5 * gFrontWidthEms, Percent));

Thank you for documenting the type of the unit in name of the variable, very helpful!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list