[Webkit-unassigned] [Bug 81558] Web Inspector: CodeGeneratorInspector.py: switch Runtime, Network and DOM domains to typed API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 17:31:35 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81558





--- Comment #22 from Timothy Hatcher <timothy at apple.com>  2012-03-21 17:31:34 PST ---
(In reply to comment #15)
> (In reply to comment #11)
> > (From update of attachment 133104 [details] [details])
> > Please revise the ChangeLog and provide information on what changed and why (overall summary and per function).
> > 
> > More info with an example: http://www.webkit.org/coding/contributing.html#changelogs
> 
> Hi Timothy
> The change is pretty much mechanical. In all functions of 3 listed domains InspectorObject and InspectorArray are completely replaced with corresponding auto-generated types from TypeBuilder according to Inspector.json protocol definition.
> Are you sure you want this description per function? This is a mechanical work, and all I can write in functions is probably a repeating statement or retell the raw diff.
> Peter

The new comment at the top of the ChangeLog is good. Thanks for adding that. Per function comments in this case are not needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list