[Webkit-unassigned] [Bug 81408] visual word movement: using cache to decrease the number of collectLeafBoxesInLogicalOrder on RootInlineBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81408





--- Comment #8 from Xiaomei Ji <xji at chromium.org>  2012-03-21 15:12:35 PST ---
(From update of attachment 133120)
View in context: https://bugs.webkit.org/attachment.cgi?id=133120&action=review

> Source/WebCore/editing/visible_units.cpp:-374
> -        Vector<UChar, 1024> string;

I moved this to outside of loop (it is always clear-ed before use in wordBreakIteratorForMinOffsetBoundary() and wordBreakIteratorForMaxOffsetBoundary().

> Source/WebCore/editing/visible_units.cpp:407
> +            iter = wordBreakIteratorForMinOffsetBoundary(visiblePosition, textBox, previousBoxLength, previousBoxInDifferentBlock, string, leafBoxes);

After sync, this function's parameter becomes a bit lengthy. Do you think it is better to inline those 2 functions (wordBreakIteratorForMinOffsetBoundary and wordBreakIteratorForMaxOffsetBoundary) or worth to introduce a struct to hold those parameters? Neither of them sounds elegant for me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.