[Webkit-unassigned] [Bug 81828] An automated tool in the patch submission process should complain about ChangeLogs without comments

Wed Mar 21 15:08:21 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=81828

Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org

--- Comment #17 from Dirk Pranke <dpranke at chromium.org>  2012-03-21 15:08:20 PST ---
(In reply to comment #2)
> I think an OOPS per file would be enough. Also adding a space after the colon for each function would make editing easier and cause style warnings about trailing whitespace (and is less heavy handed as adding OOPS.)

Most of my changes would (IMO) gain no clarity from commenting each function or each file that is changed; generally I think having a few sentences or a paragraph underneath the subject/bug/reviewer lines is sufficient, and I actually wish that the text wasn't there (I will grant that there are some cases where having per-file or per-method comments have been helpful).

Further, generating the list of files and functions that have changes can be fragile; if I generate a changelog, and then make changes to the patch, the changelog can get stale, and recreating it is even more of a hassle - this means that I often have to throw away the changelog I wrote and create a new one, just to be sure that it's up to date. Perhaps merging can make this better, but I'm skeptical.

I would much rather address this through culture and convention than through strict checking via a tool.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.