[Webkit-unassigned] [Bug 81828] check-webkit-style (and the style bot) should complain about ChangeLogs without comments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81828





--- Comment #12 from Brady Eidson <beidson at apple.com>  2012-03-21 14:02:10 PST ---
(In reply to comment #11)
> > Stating that stylebot has precisely one goal is a bit disingenuous.
> 
> Given that I created the style-queue [1], I can say with authority what my goals were in creating the bot.  To wit:
> 
> [[
> The primary goal of the style-queue is to reduce review latency by (1)
> giving immediate feedback to contributors and (2) making human
> reviewer more efficient by relieving them of mechanical tasks (like
> asking for tabs to be replaced with spaces).
> ]]
> 
> https://lists.webkit.org/pipermail/webkit-dev/2009-November/010649.html

Fair enough.  I suppose it was a mistake to equate a singular design goal with the multiple tangible benefits seen in practice.

One substantial collateral benefit was that we actually *caught* style problems that reviewers weren't catching by themselves.

That's what Tim and I are advocating for here; A tool to do the similar task of catching sloppy ChangeLog use that reviewers are not catching by themselves.

You seem to be very against further conflating of the stylebot for this task.  Perhaps we should create a second tool that also runs against every patch, and remove the ChangeLog enforcement responsibilities that stylebot currently has.

> The scope of this discussion is getting beyond what's appropriate for a bug thread.  I'd encourage interested folks to take this discussion to webkit-dev.

Definitely seems like it deserves a webkit-dev discussion.  That doesn't make this bug WONTFIX.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.