[Webkit-unassigned] [Bug 81828] check-webkit-style (and the style bot) should complain about ChangeLogs without comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 21 13:37:56 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81828





--- Comment #7 from Adam Barth <abarth at webkit.org>  2012-03-21 13:37:55 PST ---
> It already "nags" for missing bug URL, etc. Why is this not important enough to complain about?

I don't have statistics, but I don't believe that check fires very much.  We search and see whether folks who received that message were happy and changed their patch or whether they ignored it.  If they ignored the message, we should remove it.

> As long as the style bot is what forces us to fill out our TPS reports, it should make sure we do so correctly.

That's not the goal of the style bot.  The goal of the style bot is to save reviewers from pointing out obvious mistakes in a patch that a computer can flag.  That makes the project more efficient because reviewer time is a precious resource.

> It is clear we need such a tool.

Is it?

> Maybe revoking reviewer status would be a better tool?

I think you're being hyperbolic.  I suspect folks would laugh you off the mailing list if you actually tried doing that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list